The Glowfic Constellation

[pedromvilar]

So I marked a thread as unread after accidentally clicking a deep link (this one https://glowfic.com/posts/709) and it is indeed not in my opened threads list but the daily report shows the little green arrow on it for some reason

[Throne3d]

This is due (I think) to how you can now ignore a post while leaving it unread, which was added a week and a half ago. I've figured out how to fix it which should just be waiting on a review, now. Thanks!

(Technical reasons: previously, post views would always contain a 'read_at' timestamp if you'd opened the post, and if you hid a post it would accordingly have a post view and so be marked read, but when you marked it unread it deleted the whole thing; to fix this, I allowed post views to have nil 'read_at' timestamps, indicating you've read it but still have it ignored or whatever, but some places in the code still expect 'has a post view' to indicate 'has not marked / left the post unread' – this was one of them. It'll be adjusted to expect 'has a post view that has a non-nil read_at' to indicate that.)

[Moriwen]

The character editor does a weird overlap-y thing with the icons that sometimes makes it hard to select things.

http://i.imgur.com/fvykZEy.png

[Marri]

Well, technically it only does that if your gallery names are reeeeally long xD (<33333) but I'll poke at the CSS to try to make it behave better

[Moriwen]

Well if there were some kind of tagging system for galleries my names wouldn't have to include all the metadata in them ...... :P (<3333333)

(if this is in fact just affecting me don't worry about it, it doesn't bother me that much, there are better uses of your time. like having a nice bubble bath. I feel like you're owed a nice relaxing bath around now.)

[Anya]

For some reason whenever I try to expand any of my galleries it just.. doesn't?

[Marri]

Hm. It can't load the galleries/index.js file for some reason. The other javascripts aren't missing. Could be a Rails 4 thing I guess? Poking at it now.

[Marri]

Yup, Rails 4 was forbidding Javascript files named index.js for some reason. Renamed it to expander.js and now it works. Confused shrugs go here, enjoy the newly re-functional galleries. Also fixed the +/- to be up/down for Alicorn, since having two +s with different meanings basically on top of each other was weird. If they're invisible on your layout, lmk and I can poke at coloring.

[Anya]

Great, good job!

[DanielH]

Some comments on what has happened here for the several weeks I wasn’t checking forums:

I like the forum daily report for the ability to see new threads since <date>. New threads since I last checked is ideal, unless it failsbtobread my mind about when I last checked, which I expect it would. In particular, if I accidentally go to the page and then don’t open the threads that interest me, I don’t know how it could know I haven’t actually checked for new threads.

Relatedly, I agree with Adelene and Unbitwise re: refreshing unread links. Sometimes a refresh can happen without the user explicitly requesting one. These can include the browser crashing, rebooting a computer without checking all open URLs, or a mobile browser unloading the page. There’s even a bug in Chrome I’ve run across a few times where it refreshes for no reason I can determine. Ideally GET requests aren’t supposed to change anything on the server side. In practice, “unread position” is an obvious exception, but they should still be refresh-safe.

I would be fine with this being a user setting. I agree the default for existing users, by principle of least surprise, should be that hitting refrsh advances to the next page. But by that same principle I would advocate the default for new users being a redirect to the appropriate page