Page 71 of 235

Re: The Glowfic Constellation

Posted: Thu Aug 18, 2016 11:18 pm
by Marri
Hm. Restarting did make a pretty legitimate difference on the app performance; that said, I seem to be on WEBrick, so going to deploy Puma configs and see if that helps more. Please let me know if you keep seeing Application Errors; I'll keep tracking performance on NewRelic.

Re: The Glowfic Constellation

Posted: Thu Aug 18, 2016 11:46 pm
by Ezra
Ezra wrote:This imgur gallery should show you Jeffy (a short name) and Enthusiastic Seeker of Novelty (a long name) in both display and composition modes.
Did you get these screenshots? I haven't seen acknowledgment.

Re: The Glowfic Constellation

Posted: Fri Aug 19, 2016 6:55 am
by Marri
I did, sorry! I've been struggling working on it because I can reproduce on my phone but not in my browser's handy Pretend I'm a Phone mode, which is less than useful for developing, but I'm trying :) Also I might just go ahead with the 100px vertical thing; there's not that many odd sized icons.

Re: The Glowfic Constellation

Posted: Fri Aug 19, 2016 1:06 pm
by DanielH
Another option would be to add columns to the database for icon width and height.

Re: The Glowfic Constellation

Posted: Fri Aug 19, 2016 11:22 pm
by Anya
So me and Bluelantern/Faceless/CuriousDiscoverer have a character that we share. Is there anyway that we can have a shared template thing that we can each add different instances to?

Re: The Glowfic Constellation

Posted: Sat Aug 20, 2016 12:33 am
by Marri
Turns out, including a library that shames me for having low test coverage is at least at for the moment a really good way to get me to write tests. I will not bore you with the list of tests I wrote, but we have gone from 51.55% code coverage to 58.02% code coverage. (This is still embarrassing. As context: you can basically test a single endpoint that does nothing but return an empty response and get 32% coverage. I'm working on it.) I made a couple of minor tweaks to things and found some unused code, but I don't think I found any actual bugs. (Is that comforting or worrying? TBD.)

100px height thing is up; let me know if it's doing weird things to anyone's layout please, or Ezra, if it doesn't fix your layout issues. I will consider database columns as an option if I ever do actual image processing pre-upload; I'm sure I'll have to eventually, but I'm avoiding it as long as I can possibly get away with it.

I have "shared characters" on the list, but it sounds like you want shared templates? Or would a shared character work, or would you like both, or?

NewRelic looks tentatively promising on the Puma server; my middleware graphs smoothed out a lot. Will keep an eye on it.

Re: The Glowfic Constellation

Posted: Sat Aug 20, 2016 12:35 am
by Anya
Shared character would work, but a shared template would be ideal. :)

Re: The Glowfic Constellation

Posted: Sat Aug 20, 2016 5:30 am
by Kappa
The little character infocard in the new reply interface is mysteriously really tall now, like it's got an extra icon's worth of vertical space.

Re: The Glowfic Constellation

Posted: Sat Aug 20, 2016 5:42 am
by pedromvilar

Re: The Glowfic Constellation

Posted: Sat Aug 20, 2016 6:51 am
by Throne3d
It's probably 'cause the keyword thing, for some reason, has the "post-icon" class attached to it. (I'm not clear why.)