Page 32 of 235
Re: The Glowfic Constellation
Posted: Sun May 08, 2016 9:05 pm
by Marri
I hadn't pushed Throne3d's fix cause there's a CSS change I wasn't sure of, but I cherry picked the spell check change, should work now.
Also, favicons are kind of a mess even without dynamically generating them; browsers cache them and are sort of horrible about them generally. My issues with moiety colors aside, I don't think messing with favicons is a good plan; I doubt it will even attempt to work :/
Re: The Glowfic Constellation
Posted: Wed May 11, 2016 6:10 am
by pedromvilar
jalapeno_dude wrote:I just want to interject to note that by my count there 26 GC + 5 DW threads that have updated in the last 24 hours, including 9 GC + 2 DW threads that have updated
within the last hour. Truly we live in the best of times for glowfic!
(And we should all thank Marri again for creating the Glowfic Constellation, which seems to have played the biggest role in this dramatic increase in the amount of glowfic!)
<3 best marri
Re: The Glowfic Constellation
Posted: Wed May 11, 2016 11:52 am
by Marri
<3333333 I love you all. You write me things to read! It's great!
(I feel so neglectful of the site ;_; it's team week at work and I'm SO FREAKING BUSY. Until, like, Tuesday. But hopefully soon!)
Re: The Glowfic Constellation
Posted: Wed May 11, 2016 11:28 pm
by jalapeno_dude
Either bug or confusing feature:
Out of the Blue showed up in Unread Threads for me as last modified May 11th at 8:37 AM. The First Unread post took me to the top of the last page of the thread. The first post was not shown.
The reason the thread showed up as unread for me was purely that it was closed. Is that intended behavior? I think it is, and it probably should be. But I'm not sure this is the best way to indicate that. If it were up to me, I'd add a note *after* the last comment stating that the thread had closed and the time at which it had been closed, and then the First Unread link would go to that note.
Another possibility would be to put that note in the first post--but if that's the case, the first post should be displayed by default in this situation (as a result of clicking on the First Unread link for a thread marked as unread because it's been closed). And there should be a note in the
post history--right now the final edit and the one before that are identical, which is very confusing.
Two more incidental notes: First, that post history I just linked is a very large page (>37k lines and 1.5 MB of HTML) which seems to take a very long time to generate (after a Ctrl+F5, 32 seconds until the last text on the page was loaded, another 25 or so before Chrome said the page had finished loading). Looks like there's a copy of the first post for every time any comment was made or edited, or something like that, which definitely isn't right.
Second, the icon in the top right corner of posts/comments which links to the relevant page in /posts or /replies should have hover text of some sort, as well as potentially a different icon than the "First Unread" icon on the Unread Threads page, just like this board differentiates between

and

.
Re: The Glowfic Constellation
Posted: Thu May 12, 2016 10:46 pm
by Marri
The "posts are unread when they are marked close" thing is a symptom of a larger issue, in which I've been using post.updated_at for post's unread times, but because of how Rails works it gets changed upon post edit as well. It's a little annoying to fix because of said Rails magic; it's doable, it's just more work than you'd think it is, so it wasn't as straightforwards as "editing a reply should not update the post." It's on the list.
About post history - yeeeeah that's a bug. I used to only touch the updated_at field when you posted a reply, which that auditing would skip, but now I cache a couple fields and didn't skip them. Ugh. Good catch, thank you!
Those icons are sort of included in my "I'm bad at design and am using an old set of free icons which frequently fails to provide me with good icons for my usecase" mental bucketing, but I made a specific issue for those two icons to remind me.
So fixes that just went out:
- Horrible bug caught above is fixed. I no longer spam the database with "post edits" for every reply. I have gone through and deleted old ones, too, so history pages should be back in a good state.
- The hover text for the permalink in the top right of posts/replies is now "Permalink"
- Throne3d has fixed it so that saving a draft takes you to the last page, not the first
- Throne3d has improved a couple places where going to page=unread wouldn't always properly figure out that you were on the first or last page when making UI decisions like "gray out link to last page" or "hide top post"
- Throne3d has fixed an issue with creating relative links when using the RTF editor
Re: The Glowfic Constellation
Posted: Thu May 12, 2016 10:52 pm
by rockeye_stonetoe
Hyperlinks don't seem to work.
Chrome. I get a 'editing window' cursor when I hover over one and can't click through.
Re: The Glowfic Constellation
Posted: Thu May 12, 2016 10:57 pm
by Marri
Hyperlinks where? I just tested the ones on the Unread page and the permalinks in the top of a post on my Mac Chrome and both worked as expected.
Re: The Glowfic Constellation
Posted: Thu May 12, 2016 11:00 pm
by rockeye_stonetoe
Re: The Glowfic Constellation
Posted: Fri May 13, 2016 8:18 am
by Marri
Okay so two issues:
Yours had somehow gotten nested, which is fascinating. <a href=\"<a href="http:/media.treehugger.com/assets/images/2011/10/yamaha_bicycle_taxi.JPG">\" target=\"_blank\">mental image</a> (see how there's aa <a href> within a <a href>?) I went into the database and fixed it by hand.
When I posted one of my own
here it decided
all links are relative, which is not the point. Need to argue with it about that, that is very bad.
Re: The Glowfic Constellation
Posted: Fri May 13, 2016 8:22 am
by Throne3d
Marri wrote:When I posted one of my own
here it decided
all links are relative, which is not the point. Need to argue with it about that, that is very bad.
That URL is invalid – "http:/media" should be "http://media". It works if you have the extra slash.
(See
here.)