Alicornutopia

It has been like a week or two since I've had "visited" link colors on page numbers. It's a small inconvenience.

The page numbers that appear when reading a post or the ones that appear in [brackets] when selecting the post from a list or both?

The ones at the tops and bottoms of pages in threads. I've been accessing them via Daily Report links, if it matters.

Ezra wrote:The ones at the tops and bottoms of pages in threads. I've been accessing them via Daily Report links, if it matters.

It's probably due to the fact those URLs are on /replies/id#reply-id, and that varies based on each and every single reply link for the thread, so it won't show up in your history properly.
I'm not sure of a nice way to fix this, except maybe telling the Javascript all the reply IDs in a thread, telling it the thread ID, then getting it to poll your history for all pages you've seen on that thread based on those replies? But that would be ugly and difficult to implement, as well as probably slow and buggy, because you'd also have to work out what pages the individual replies are on?

Unless I'm over-complicating things, it seems like it'd be difficult to fix.

Can’t you tell JS that the page you are currently on is really a different page? Then it would just automatically show up correctly.

Throne3d wrote:

Ezra wrote:The ones at the tops and bottoms of pages in threads. I've been accessing them via Daily Report links, if it matters.

It's probably due to the fact those URLs are on /replies/id#reply-id, and that varies based on each and every single reply link for the thread, so it won't show up in your history properly.
I'm not sure of a nice way to fix this, except maybe telling the Javascript all the reply IDs in a thread, telling it the thread ID, then getting it to poll your history for all pages you've seen on that thread based on those replies? But that would be ugly and difficult to implement, as well as probably slow and buggy, because you'd also have to work out what pages the individual replies are on?

Unless I'm over-complicating things, it seems like it'd be difficult to fix.

And I don't think there's a way for me to do the DR links that doesn't trigger that. If there is, or there could be made to be, I can switch, though.

DanielH wrote:Can’t you tell JS that the page you are currently on is really a different page? Then it would just automatically show up correctly.

Well it could, but I think that would mess up people's histories and, to be honest, I think you might as well just have the /replies/id thing be a permalink to the applicable page of the thread? But people didn't seem to like that idea before.

Adelene wrote:And I don't think there's a way for me to do the DR links that doesn't trigger that. If there is, or there could be made to be, I can switch, though.

You probably couldn't do it very easily, since you'd have to link to a specific page of a thread to get the reply on the page, and that has the previous issue of different per_page settings – I think it'd have to be fixed on the Constellation's end.

Could the links be page-based, even when the initial URL is reply-based?

I feel like the easy way to fix it is to try and force the pagination to use the /posts link rather than the /replies link. Then the DR can keep using the /replies link but the pagination will display Already Read correctly. I'll put it on the issues list.

EDIT: Yes, totally what Ezra said.

Pushed a thing that should force pagination to use /posts instead of /replies when viewing a post. Let me know if you see weird behavior.