Page 23 of 235

Re: The Glowfic Constellation

Posted: Wed Apr 13, 2016 4:07 pm
by Marri
Yeah, like Throne3d said, it would be more "on load, check if content is a single space; if so, replace with nothing." The check for it being exactly a random space is obviously very important to not breaking Firefox's preservation :)

Re: The Glowfic Constellation

Posted: Wed Apr 13, 2016 8:09 pm
by Marri
tl;dr the Firefox thing should be fixed now.

For those interested in tech:

The thing Firefox was doing is in fact a special behavior for textareas. It can be turned off by the attribute autocomplete=off, but obviously I didn't want to do that. Digging around in the TinyMCE code finally got me to the method tinyMCE.activeEditor.getContent, which accepts an optional argument to return raw html. So I wound up with the following code in my tinyMCE.onInit() method:

Code: Select all

      var rawContent = tinyMCE.activeEditor.getContent({format: 'raw'});
      var content = tinyMCE.activeEditor.getContent();
      if (rawContent == '<p> <br></p>' && content == '') { tinyMCE.activeEditor.setContent(''); }
Which checks for the extremely specific case where the plaintext content is empty (correct) and the raw html content is a paragraph containing a non-breaking space and a line break (...wat) and then resets the content to be actually blank.

...welcome to front end development, there's a reason I'm a server dev? xD

Re: The Glowfic Constellation

Posted: Sat Apr 16, 2016 11:55 am
by Marri
Updates:
  • If you try to edit or delete a continuity when not logged in, it now properly displays an error message instead of crashing.
  • If you tried to view a user's characters and the user could not be found, it now properly displays an error message instead of crashing.
  • If you have HTML as your default editor and you save a draft, it will no longer incorrectly display blank content.
  • When updating your password, it now actually validates that the new one matches the confirmation one.
  • When updating your password, it now actually validates your password length.
  • When updating your password, it displays actual errors if you fail, rather than "Something went wrong."
  • Emails will now display as from 'Glowfic Constellation <email>' instead of just the email
  • If you have an email address set on your account, there is now a Forgot Password? reset option.
  • Throne3d added a bunch of query improvements to make things faster
(Gee, can you tell I've been writing tests this weekend?)

Re: The Glowfic Constellation

Posted: Sat Apr 16, 2016 1:37 pm
by Kappa
<333333333333333333333333333333

good marri best marri

Re: The Glowfic Constellation

Posted: Sat Apr 16, 2016 1:39 pm
by pedromvilar
Kappa wrote:<333333333333333333333333333333

good marri best marri
+1

Re: The Glowfic Constellation

Posted: Sun Apr 17, 2016 6:17 am
by Marri
<3333333s

Re: The Glowfic Constellation

Posted: Sun Apr 17, 2016 12:10 pm
by rockeye_stonetoe
Request: "New Post" editing window embiggened. It's awkward to write long top posts in it.

Re: The Glowfic Constellation

Posted: Sun Apr 17, 2016 5:41 pm
by Marri
Post window has been embiggened by about 2.5x and Rich Text mode now has a vertical resize option if you need more than that. HTML mode should already have the resize; lmk if it doesn't, might be browser-specific.

Also I stuck in user layouts. So far the only options are Throne3d's Dark and Iconless modes; I literally copy/pasted the CSS and did not actually sanity check them in any way. If people have requests for additional things to be changed / specific hex codes / their own CSS they'd like added as an option, just let me know, it's pretty easy to add. (cc @teceler :D) (Ideally long term all layouts would be fully tested and iconless would be an option independent of layout colors, but that is for another day.)

Also Throne3d fixed a bug where the site crashed when you tried to mark a post complete. (I suspect this also applied to marking a post unread, but same fix should apply.)

Re: The Glowfic Constellation

Posted: Sun Apr 17, 2016 5:48 pm
by pedromvilar
I don't know if it's a coincidence but when I saved my CSS thing to iconless I got a "something went wrong" error and now I can't access constellation anymore.

Re: The Glowfic Constellation

Posted: Sun Apr 17, 2016 5:53 pm
by Marri
Man, I love it when production does things differently then development.

I set your layout back; I'll have a fix up shortly. Has to do with how production compiled CSS files vs how development does it. Oy.

EDIT: All better, layouts are working for me in production as well, I'll put yours back.