Page 22 of 235
Re: The Glowfic Constellation
Posted: Mon Apr 11, 2016 11:16 pm
by Marri
@jalapeno - made an issue, if you personally happen to want a list / me to unhide something I can grab that for you while the feature's not built
Updates: Aestrix requested a way to save drafts. There is therefore now a way to save drafts of replies. Happy belated birthday <3 Also, threw in a WYSIWYG editor while I was at it, it's fairly customizable, feel free to request more/fewer buttons or whatever. You can toggle between it and the plain HTML editor, and there's a user setting to set your default.
Re: The Glowfic Constellation
Posted: Tue Apr 12, 2016 5:04 am
by Aestrix
<3
Thank you Marri!
Re: The Glowfic Constellation
Posted: Tue Apr 12, 2016 5:46 am
by Adelene
The new reply box is neat!
Unfortunately it messes with how the keyboard controls work on mobile (dunno regular browsers) in various ways that make it much less usable. :/
Re: The Glowfic Constellation
Posted: Tue Apr 12, 2016 6:21 am
by pedromvilar
I just wanted to remind everyone that Marri is great
Edit: Is the <p></p> necessary? It makes a bizarre space appear before text that looks weird to my eyes.
Re: The Glowfic Constellation
Posted: Tue Apr 12, 2016 8:25 am
by Throne3d
pedromvilar wrote:I just wanted to remind everyone that Marri is great
Edit: Is the <p></p> necessary? It makes a bizarre space appear before text that looks weird to my eyes.
It's not totally necessary, but really it's better form to do that anyway. I've suggested ways to Marri to fix it and another issue.
Code: Select all
.post-content > p:first-child { margin-top: 0; }
That should fix the top paragraph giving extra spacing ^.
Multiple paragraphs in a row also results in weird spacing, because it uses both <p> tags and also <br /> tags due to linebreaks. This can
probably be fixed by just not automatically adding <br /> tags if the post content contains <p> or <br /> tags. Alternatively, the site could allow the user to check a box saying "Don't automatically add linebreaks" in HTML mode, and automatically check this box if you're in Rich Text mode.
Re: The Glowfic Constellation
Posted: Tue Apr 12, 2016 11:13 pm
by Marri
Updates for the evening: I put in Throne's CSS fix for the first paragraph element not having a top margin, so hopefully that'll clear up the weird top spacing for RTF posts (including old ones). I put in the hacky "don't sub linebreaks if paragraph tags exist" fix to avoid double spacing. I fixed a bug with paginating posts when viewing a character / user / continuity where the first/last links were wrong. I fixed or at least improved a thing where swapping between RTF and HTML made the RTF entry win every time, because whyever would the RTF editor's website have the correct code to toggle the editor, that would be helpful, they just straight up had the wrong code so I've now hunted that down and fixed it. And that's definitely my limit for drunk bugfixing (sake-based karaoke is an important life goal okay) soooo to bed with me now.
Re: The Glowfic Constellation
Posted: Wed Apr 13, 2016 11:56 am
by RoboticLIN
Bug report! After hitting refresh, the reply box has a single space put into it. This only affects Firefox, and not Chrome (tried on both).
Re: The Glowfic Constellation
Posted: Wed Apr 13, 2016 3:42 pm
by Marri
Seems to be related to the way Firefox attempts to preserve information entered in forms when you hit refresh, which Chrome does not. Will attempt to hack together something in Javascript to adjust for it when I'm home from work.
Re: The Glowfic Constellation
Posted: Wed Apr 13, 2016 3:55 pm
by DanielH
I would prefer not trying to mess with the browser trying to preserve data. Even if it sometimes messes up, it’s still good when it prevents you from losing something you were in the middle of typing.
Re: The Glowfic Constellation
Posted: Wed Apr 13, 2016 3:58 pm
by Throne3d
DanielH wrote:I would prefer not trying to mess with the browser trying to preserve data. Even if it sometimes messes up, it’s still good when it prevents you from losing something you were in the middle of typing.
I'm assuming it was that if the browser preserves data and the data is
blank (or alternatively a paragraph tag and otherwise blank, when you strip out the spaces), it would set the content to be
actually blank, so it still preserves data but doesn't leave random spaces.