Page 187 of 235

Re: The Glowfic Constellation

Posted: Sat Mar 11, 2017 12:49 pm
by pedromvilar
+1

Re: The Glowfic Constellation

Posted: Sat Mar 11, 2017 2:55 pm
by Throne3d
Currently it takes you to the last page of the post. I could have it take you to the last unread point instead, which would correspond to "top of the editor" in, like, the overwhelming majority of cases?

I can implement a link to the editor in the last page of a post, but as far as I know we don't yet do that anywhere, whereas we do often link to the unread point, which as a side effect often points to the reply editor (such as in the tags owed menu). It might be neater to stick to that?

Re: The Glowfic Constellation

Posted: Sat Mar 11, 2017 6:06 pm
by Kappa
Having it take you to unread does seem tidy.

Re: The Glowfic Constellation

Posted: Sat Mar 11, 2017 6:17 pm
by DanielH
And, in the cases where this does not take you to a reply form, it also sounds plausibly more useful.

Re: The Glowfic Constellation

Posted: Sat Mar 11, 2017 6:26 pm
by Throne3d
It sounds kinda weirdly… almost inconsistent… but yes, more useful. (It's part of why I suggest it.)

Re: The Glowfic Constellation

Posted: Sun Mar 12, 2017 7:10 am
by pedromvilar
Bug: now whenever I switch to an iconless character it by default keeps the previous character's icon.

Re: The Glowfic Constellation

Posted: Sun Mar 12, 2017 1:20 pm
by Throne3d
In addition to this, it seems like the Firefox reload fix is broken for replies that don't have a character alias set. (If you select another character and reload the page, it won't swap to that character properly in the UI when the page loads a second time.)

I've done a fix for both of these issues, pending code review.

Re: The Glowfic Constellation

Posted: Sun Mar 12, 2017 9:35 pm
by Marri
Throne things:
- Fix for Pedro's bug
- Fix for Firefox reload fix when you don't have a character alias
- Redirect draft save to unread
- Newly recolored images for caught-up-but-want-to-jump-to-end images in Tags Owed
- Avatar text is not displayed as prominently, and only if the user doesn't have an avatar set.

Me things:
- Loading tags, settings and content warnings is now done dynamically to preserve memory. I moved the tag loading/searching functionality into the shiny new API while I was at it.
- Wrote some more tests, we're now at 97.61%
- Fixed a configuration thing with our code linter

My town's getting some snow so I now have my inlaws staying until Friday and I've got a wedding present* to focus on making so updates will be scarcer than usual.

* I picked up blank needlepoint canvases yesterday, they both need to be painted by next Saturday so I can buy thread to match the designs, so that I can bring said thread and canvases with me on my 44+ hours of flights that I will be taking between 3/20 and 4/3. Granted I've already got one painted, but my week is much less free than my weekend?

Re: The Glowfic Constellation

Posted: Sun Mar 12, 2017 11:06 pm
by Ezra
97.61%! Woohoo!

Re: The Glowfic Constellation

Posted: Sun Mar 12, 2017 11:28 pm
by Ezra
Teceler reports that there are now far too many green arrows on the Unread page. Is it intended that they now appear even on unopened threads?