Page 150 of 235

Re: The Glowfic Constellation

Posted: Wed Dec 28, 2016 5:45 am
by pedromvilar
Yeah

Also is the removal of pages from threads in continuities on purpose?

Re: The Glowfic Constellation

Posted: Wed Dec 28, 2016 6:36 am
by Throne3d
… Probably not. (You're referring to the quick-link things when looking at a continuity, right?)

Re: The Glowfic Constellation

Posted: Wed Dec 28, 2016 7:51 am
by pedromvilar
Yes

Re: The Glowfic Constellation

Posted: Wed Dec 28, 2016 8:40 am
by Timepoof
jalapeno_dude wrote:I agree with these suggestions and want to second/reemphasize the importance of putting the first unread link everywhere threads are listed. This is definitely the biggest remaining UI inconvenience for me.
++++++++++++++++

Re: The Glowfic Constellation

Posted: Wed Dec 28, 2016 9:23 am
by Marri
Merged Throne's fixes and added a memory fix of my own.

Timepoof, do you not see the unread link now...?

Re: The Glowfic Constellation

Posted: Wed Dec 28, 2016 9:27 am
by Timepoof
I do, it was more meant as extreme approval of its existence and I could not produce words at that moment and just quoting a thing was easier than waiting and remembering to come back to this.

Re: The Glowfic Constellation

Posted: Wed Dec 28, 2016 12:57 pm
by Marri
Aha! <3333

Pushed a fix from Throne for avatarless users.

Was seeing a weird failure on the Favorite page tests (the page itself was fine, the tests were just being weird) and it turned out to be a lazy-evaluation-in-tests problem. Have since fixed it, and then went on a test writing kick. (Also because I was on a plane with no wifi.) I of course did not do anything so intelligent as "systematically test a single controller"; I just would load my coverage report, write tests for the least tested file until it was no longer the least tested file, and then move on the new least tested.
Baseline with no tests: 29.49%
Before my new tests: 74.1% with 40 pending
After my new tests: 76.75% with 36 pending
WHOO.

Re: The Glowfic Constellation

Posted: Wed Dec 28, 2016 12:59 pm
by Throne3d
What's "baseline with no tests"? Tests of libraries, or?

Re: The Glowfic Constellation

Posted: Wed Dec 28, 2016 3:44 pm
by Marri
No, it's "loaded the app but ran no tests", which does get you some lines of code (class declarations and attributes and so on, which run at compile time). Everything left after that (controllers and model methods and view helpers and such) needs tests.

Re: The Glowfic Constellation

Posted: Wed Dec 28, 2016 7:45 pm
by Marri
Flight 2/2 update: 80.36% coverage. I BROKE 80, HELL YES.