The Glowfic Constellation

Do you have a setting, character, plot, art, or other notion that you wish to put on the Internet? This is the Internet! Whee!
User avatar
pedromvilar
Posts: 1172
Joined: Sun Mar 23, 2014 11:48 am
Pronouns: *shrug*
Contact:

Re: The Glowfic Constellation

Post by pedromvilar »

Yeah

Also is the removal of pages from threads in continuities on purpose?
Throne3d
Posts: 1282
Joined: Sat Oct 10, 2015 1:11 pm
Pronouns: He/him/his
Location: United Kingdom

Re: The Glowfic Constellation

Post by Throne3d »

… Probably not. (You're referring to the quick-link things when looking at a continuity, right?)
User avatar
pedromvilar
Posts: 1172
Joined: Sun Mar 23, 2014 11:48 am
Pronouns: *shrug*
Contact:

Re: The Glowfic Constellation

Post by pedromvilar »

Yes
User avatar
Timepoof
Posts: 488
Joined: Sun Nov 29, 2015 6:16 pm
Pronouns: she/her/hers
Location: On a sparkly throne with soft fluffy cushions
Contact:

Re: The Glowfic Constellation

Post by Timepoof »

jalapeno_dude wrote:I agree with these suggestions and want to second/reemphasize the importance of putting the first unread link everywhere threads are listed. This is definitely the biggest remaining UI inconvenience for me.
++++++++++++++++
The WAFFLES will submit to this indignity.
Marri
Posts: 1026
Joined: Mon Mar 31, 2014 7:47 am

Re: The Glowfic Constellation

Post by Marri »

Merged Throne's fixes and added a memory fix of my own.

Timepoof, do you not see the unread link now...?
User avatar
Timepoof
Posts: 488
Joined: Sun Nov 29, 2015 6:16 pm
Pronouns: she/her/hers
Location: On a sparkly throne with soft fluffy cushions
Contact:

Re: The Glowfic Constellation

Post by Timepoof »

I do, it was more meant as extreme approval of its existence and I could not produce words at that moment and just quoting a thing was easier than waiting and remembering to come back to this.
The WAFFLES will submit to this indignity.
Marri
Posts: 1026
Joined: Mon Mar 31, 2014 7:47 am

Re: The Glowfic Constellation

Post by Marri »

Aha! <3333

Pushed a fix from Throne for avatarless users.

Was seeing a weird failure on the Favorite page tests (the page itself was fine, the tests were just being weird) and it turned out to be a lazy-evaluation-in-tests problem. Have since fixed it, and then went on a test writing kick. (Also because I was on a plane with no wifi.) I of course did not do anything so intelligent as "systematically test a single controller"; I just would load my coverage report, write tests for the least tested file until it was no longer the least tested file, and then move on the new least tested.
Baseline with no tests: 29.49%
Before my new tests: 74.1% with 40 pending
After my new tests: 76.75% with 36 pending
WHOO.
Throne3d
Posts: 1282
Joined: Sat Oct 10, 2015 1:11 pm
Pronouns: He/him/his
Location: United Kingdom

Re: The Glowfic Constellation

Post by Throne3d »

What's "baseline with no tests"? Tests of libraries, or?
Marri
Posts: 1026
Joined: Mon Mar 31, 2014 7:47 am

Re: The Glowfic Constellation

Post by Marri »

No, it's "loaded the app but ran no tests", which does get you some lines of code (class declarations and attributes and so on, which run at compile time). Everything left after that (controllers and model methods and view helpers and such) needs tests.
Marri
Posts: 1026
Joined: Mon Mar 31, 2014 7:47 am

Re: The Glowfic Constellation

Post by Marri »

Flight 2/2 update: 80.36% coverage. I BROKE 80, HELL YES.
Post Reply