Page 132 of 235

Re: The Glowfic Constellation

Posted: Mon Nov 28, 2016 6:54 am
by Throne3d
If someone manually sets it to a certain specific resolution using the interface, it'll add "width:" and "height:" things to the style attribute of the img tag – or, at worst, if it's using old spec HTML, it'll add them as "width=" and "height=" attributes. It has to do this for the image to display at the desired resolution. So it should be distinguishable just by simply looking for the presence of these things on image tags?

Unless, I guess, the editor already does this for images at their default size, but I don't think it does…

Edit: Never mind, the editor totally does this and I have no idea how we'll check the difference between them. (Also it does use old spec HTML, so, ew.) I feel like images should at least have the "max-width:100%;" thing added, though – the "height:auto;" is, I think, just to make sure it doesn't screw up on some browsers but I don't know that it was actually necessary except to remove the height constraint if it was already present.

Re: The Glowfic Constellation

Posted: Mon Nov 28, 2016 8:06 am
by Unbitwise
Um, why are we talking about adding styles to individual images as opposed to just changing the site stylesheet?

Re: The Glowfic Constellation

Posted: Mon Nov 28, 2016 8:21 am
by Throne3d
– I wasn't really thinking about either properly, as the way it should be implemented, at this point. Just failing to think. But that's a good point.

It doesn't actually change my solution, though, which is to just add "max-width:100%;" and probably ignore adding "height:auto;" unless past-me actually had a reason for that. :P

Re: The Glowfic Constellation

Posted: Mon Nov 28, 2016 8:28 am
by Unbitwise
Another good thing to do might be to put it in the stylesheet with something like

Code: Select all

img:not(.custom-image) {
  max-width: 100%;
  height: auto;
}
This way future writers can say <img class="custom-image" ... to mark an image they want styled a particular way rather than overriding whatever the stylesheet does (in case we later decide we like all default images centered or something). And this is way easier to change later than auto-inserting anything from the editor.

Regardless, you do need the auto part: it's not the default and if you leave it out, the image will be squished instead of shrunk (not preserving aspect ratio).

Re: The Glowfic Constellation

Posted: Mon Nov 28, 2016 9:17 am
by Shoal
I wanted to temporarily mark Sandboxes as hidden, so that i could look through the unread page faster, but when I went to unhide it, it didn't work. I initially hid it through the "Mark entire continuity" box. Sandboxes is no longer listed as hidden on this page: https://vast-journey-9935.herokuapp.com/posts/hidden, but posts from Sandboxes don't show up on my Unread page.

Re: The Glowfic Constellation

Posted: Mon Nov 28, 2016 10:21 am
by Marri
@Shoal hiding it also marks it as read; I can remove that for you after work if you like.

Re: The Glowfic Constellation

Posted: Mon Nov 28, 2016 10:49 am
by Shoal
thanks, I appreciate that.

Re: The Glowfic Constellation

Posted: Mon Nov 28, 2016 8:32 pm
by Marri
My previous memory fixes did not compensate for the fact that upgrading Ruby is murder on my memory consumption. With two workers we were getting memory errors and response time alerts; we're now down to one worker, which spares me the memory errors but increased the response time alerts. So I'll be heads down for the foreseeable future trying to eliminate objects wherever I possibly can to get memory usage low enough that I can bump us back to two workers. (I can spin up more dynos, but I really want to get two workers per dyno first; additional dynos are $7/mo, and changing my existing dyno to have more memory changes the price from $7/mo to $50/mo, so TUNING ON EXISTING DYNO IT IS.)

@Shoal your thing is gone now.

Re: The Glowfic Constellation

Posted: Tue Nov 29, 2016 1:33 am
by Shoal
thank you Marri! I appreciate it a lot!

it's nice not having to have 10 tabs open in my browser for all the stuff i'm following now and it's nice to have a dark background and it's nice to have everything in my own time zone and it'll be easier now to notice if something i was reading stops and starts again. this is all really great.

Re: The Glowfic Constellation

Posted: Wed Nov 30, 2016 5:12 am
by pedromvilar
Suggestion/request: It seems like authors should be picked at thread creation and the thread should be locked to them by default.