Page 126 of 235

Re: The Glowfic Constellation

Posted: Thu Nov 24, 2016 8:28 pm
by DanielH
Yeah, all three have separate cookies. I’m logged in separately on www., glowfic.com, and vast-journey.

Re: The Glowfic Constellation

Posted: Thu Nov 24, 2016 10:55 pm
by Marri
Updates:
- The old /users/:id/templates link now permanently redirects to /users/:id/characters, because apparently Google has failed to notice that I did a thing and I've gotten a couple errors.
- Test coverage has gone from 70.08% to 71.54%
- I have switched from using the Haml gem to parse my Ruby-generating-HTML templates to the Hamlit gem, a higher performance implementation.

Longer dump on performance and Hamlit:

Things are still slow. 80% of all processing time is still spent on displaying posts, so clearly that's the thing to work on. I poked at caching more things, but my Redis is already running full-and-evicting, and upgrading to double space is $15/mo, so that's going on the back burner for now. I could improve database queries, but a good 50% of the time is just in view rendering, and another 23% in controller processing (which as near as I can tell is counted separately from database calls), soooo the thing to improve is clearly view rendering. So we're trying Hamlit, and if that fails I try more things I guess? There's a super cool looking garbage collection tuner I want to try, but it looks designed for Ruby 2.1 and we're on 2.0 and I don't want to upgrade without more test coverage and you'll notice how I've been adding test coverage?

Dealing with login cookies is on the list somewhere but my mental list has tests/performance ahead of them.

Re: The Glowfic Constellation

Posted: Fri Nov 25, 2016 5:56 am
by Throne3d
In case people would like to give feedback, Marri has done an automated reports page on the Constellation!

I personally think days should be split by Hawaii time (as in, where it says 'Nov 24, 2016', that should cover replies up to Nov 25th 10am UTC) since that approximately fits to have midnight be the end of a day of tagging. 10am GMT is when I currently split days in the report – usually people on the west coast are done tagging by that point and the next day of tagging has not quite started, and I think Adelene used to split the report days like that.

It would, however, cause the timestamps to show up weirdly (since it'd show e.g. "4am" under the previous day, but 5am under the current day, if you were on the east coast?) and currently we're not sure of a good solution to this – I suggested a button for 'Hawaii' split vs 'local' split, so that then you know you've set it to a bizarre day-split and are correspondingly less confused by the timestamps, but this may not be the best system. Also sorting columns is probably a good idea, and is (sort of) on the todo list.

The forum reports will probably continue for a while, since I'm not sure how attached people are to the current method versus that one, but it'd be nice to get feedback on it.

Re: The Glowfic Constellation

Posted: Fri Nov 25, 2016 8:15 am
by Adelene
Throne3d wrote:I personally think days should be split by Hawaii time (as in, where it says 'Nov 24, 2016', that should cover replies up to Nov 25th 10am UTC) since that approximately fits to have midnight be the end of a day of tagging. 10am GMT is when I currently split days in the report – usually people on the west coast are done tagging by that point and the next day of tagging has not quite started, and I think Adelene used to split the report days like that.
I actually did something slightly more complicated than that; if a thread was still actively being tagged at - I think it was 4am, here in Central time? - then I wouldn't count that as the next day, but if it started tagging after that I would. A computer could be taught to do that - compare this timestamp to the last one and if they're within the hour it's still the previous day's - but it'd be somewhat less straightforward and perhaps more confusing to see as an automated behavior.

Re: The Glowfic Constellation

Posted: Fri Nov 25, 2016 9:27 am
by pedromvilar
I'm not entirely sure threads that updated yesterday and today should appear only today rather than being duplicated, but don't super have opinions about this.

And perhaps rather than stopping showing updates after 7 days it could have no limit? But only load when people get down there? à la Google Images

As for times, perhaps the report days should be in the timezone of the user?

Re: The Glowfic Constellation

Posted: Fri Nov 25, 2016 9:55 am
by Throne3d
pedromvilar wrote:And perhaps rather than stopping showing updates after 7 days it could have no limit? But only load when people get down there? à la Google Images

As for times, perhaps the report days should be in the timezone of the user?
The Google Images-type thing would be doable but would require we add AJAX calls for this sort of thing, which would probably make it quite a bit more complicated than it already is. (Maybe sometime, though?)

The report days currently are in the timezone of the user and I find it very bizarre since I look at the list and see that a ton of threads have been updated "today" – I'd much rather be able to see "yesterday" 's tag counts all combined, so I know e.g. how many times Alicorn and lintamande tagged in some thread. Currently I'd have to go alter my timezone to be Hawaii and reload the list and that seems annoying.
Adelene wrote:I actually did something slightly more complicated than that; if a thread was still actively being tagged at - I think it was 4am, here in Central time? - then I wouldn't count that as the next day, but if it started tagging after that I would. A computer could be taught to do that - compare this timestamp to the last one and if they're within the hour it's still the previous day's - but it'd be somewhat less straightforward and perhaps more confusing to see as an automated behavior.
I could do that with my scraper relatively easily (I haven't yet and probably will not), but doing that on the Constellation could add quite a few more database calls.

Re: The Glowfic Constellation

Posted: Fri Nov 25, 2016 9:56 am
by Kappa
I think having each thread appear in the daily-reports-as-a-whole exactly once seems much tidier than having threads appear in all of the days where they have ever been tagged. There are a lot of threads.

Rather than infinite scroll, would some kind of paging thing do? Like, last 7 days, page back to previous 7 days, page back to 7 days before that...?

Also, I feel like we should either have some kind of convenient thing for making character/setting names in thread summaries coloured by author moiety, or ring the death toll for moiety colours as a whole.

Re: The Glowfic Constellation

Posted: Fri Nov 25, 2016 10:03 am
by pedromvilar
On the one hand moieties don't have a lot of uses

On the other one of the uses they do have is making it immediately visually obvious which pair of authors are in a thread

Plus it gives us a shorthand for "that author's characters" (Alicorn's are greens, Kappa's are purples, mine are salmons, Curious' are silvers...)

On a third hand it really really does not scale

Re: The Glowfic Constellation

Posted: Fri Nov 25, 2016 10:22 am
by Kappa
The secondary moiety colours thing makes the scaling issue slightly less of a problem, but on the other hand Marri's totally right that the aesthetics get really sketchy when every author has their own set of custom colours floating around. And there's no really good way to display secondaries in the Constellation version of the daily report.

Re: The Glowfic Constellation

Posted: Fri Nov 25, 2016 10:52 am
by Throne3d
Could have a flags column that shows daily report flags, like I currently do, generate them automatically if secondary moieties were on the Constellation… but we don't currently have them on the Constellation and I think Marri's against them for similar reasons of 'does not scale'.