Page 124 of 235

Re: The Glowfic Constellation

Posted: Mon Nov 21, 2016 12:00 am
by Marri
Updates, many of which have been up for a while but were not Formally Announced:
- Favicon is now the PBG-as-glow icon. Thanks to Kappa for tolerating my perfectionism, and to the users who dealt with the errors raised by the fact that I can't test the asset pipeline in development mode wtf why, so we now also have properly pipelined, cached and versioned favicons, with additional icons for special cases for iOS/Android/Microsoft/ughwhy.
- As penance for my pipeline issues, code coverage is up from 62.21% to 70.08%
- Flat view now respects user layouts (hi Maggie)
- Continuities are sorted by name, except for Sandboxes which is pinned to the top
- The actually-announced change where you must salt your password correctly or see an annoying warning constantly
- Throne fixed a thing where templates with blank descriptions counted as "having" a description because it was '' not nil and tried to display them
- Scraped Unbitwise's posts
- When you edit a gallery, it now takes you back to the edit page, in case you wish to keep messing with keywords.

Everything not already To Do listed is now To Do listed.

Also I have not yet properly squeed over DanielH's Silmaril joke so consider this me belatedly showering more love upon it. <33333

Re: The Glowfic Constellation

Posted: Mon Nov 21, 2016 6:46 am
by Kappa
best marri!! so good!!

Re: The Glowfic Constellation

Posted: Mon Nov 21, 2016 9:20 am
by Unbitwise
I see that the scrape produced some duplicate icons in my gallery. If I keep the DW-originated new duplicates, and replace the ones I created with those, will that mean less duplication in any future scrape?

Re: The Glowfic Constellation

Posted: Mon Nov 21, 2016 9:24 am
by Kappa
Potentially yes, but I believe Marri's working on a thing that will look for matching keywords in case of potentially-duplicated icons instead of jumping straight to importing the DW-hosted version, and it is my opinion that we should be trying to minimize the extent to which we steal DW's bandwidth on the constellation.

Re: The Glowfic Constellation

Posted: Mon Nov 21, 2016 9:26 am
by Marri
Right now it does icons by "Does this Dreamwidth icon url exist in the database? No? Okay, make it." I had suggested to Kappa as a fallback that it change to "Does this Dreamwidth icon url exist in the database? No? Does an icon exist for this character with this keyword? No? Okay, make it." Would that new intermediary step solve the issue or have you also changed the keywords?

(@Kappa jinx)

Re: The Glowfic Constellation

Posted: Mon Nov 21, 2016 9:33 am
by Unbitwise
I didn't realize they were ‘hotlinked’ and will certainly convert the other way around, then. (It seems inconvenient that you can't Edit Icon and change the-actual-image-itself to an uploaded one, though I can see that the replace functionality can substitute for that.)

Re: The Glowfic Constellation

Posted: Mon Nov 21, 2016 9:36 am
by Unbitwise
Also, a UX-bug-report: I clicked on the “Set Default” thing in icon editing expecting it to set a default for that gallery, and instead it changed my account avatar.

Suggested action: Right now you set the icon for a character on the character's page and for your account by going to the icon view page. They should instead both work the same way, whichever way that is. That way having only one of the controls in one place isn't confusing.

(Also it should say something like "Set avatar for Unbitwise" instead of "Set Default" since "default" isn't really the right concept here.)

Re: The Glowfic Constellation

Posted: Mon Nov 21, 2016 9:40 am
by Kappa
The default icon on your entire account is the default icon for your entire account - it appears when you use characters with no icons of their own, iirc. But yes, I think that it would probably be a good idea to set the account-wide default icon from the account page. (I would cry, or at least post crying unicorn gifs, if setting default icons for characters required going to the individual icon page.)

Re: The Glowfic Constellation

Posted: Mon Nov 21, 2016 3:50 pm
by pedromvilar
Minor request: when uploading an icon, if you don't choose a keyword for it use the filename as keyword

Re: The Glowfic Constellation

Posted: Mon Nov 21, 2016 3:52 pm
by Throne3d