The Glowfic Constellation

[rockeye_stonetoe]

https://vast-journey-9935.herokuapp.com ... s/459/icon

"We're sorry, but something went wrong.

If you are the application owner check the logs for more information"

I cannot icons halp

[Throne3d]

https://vast-journey-9935.herokuapp.com/galleries/459/icon

"We're sorry, but something went wrong.

If you are the application owner check the logs for more information"

I cannot icons halp

What did you input? It looks like that was happening when invalid data was entered (I just did a fix, so hopefully that'll be added soon). If, for example, your URL was blank, or the keyword, it would have caused that. If you did a file upload, I haven't got an easy way to test and fix that, so you might have to wait for Marri, but if you were just adding icons via URL, it was probably an invalid input.

[Marri]

Only you have access to that link, so I can't reproduce, but I pushed a fix where if you tried to upload an icon to a gallery and an icon failed validation (like Throne3d said, invalid data), it would crash. It should now just display the list of errors.

[rockeye_stonetoe]

Yes that was the thing that happened, i was doing icons wrong.

[pedromvilar]

Uploading an icon, and then uploading another icon on the same field does weird stuff: https://gyazo.com/3a40e505cada16798e51cf691123d143

The icons probably shouldn't be uploaded until "add icon" is clicked?

Edit: (It was an accident btw I uplodaded the wrong icon first then fixed)

[Marri]

@rockeye glad to hear it's working now!

Uploading an icon, and then uploading another icon on the same field does weird stuff: https://gyazo.com/3a40e505cada16798e51cf691123d143

The icons probably shouldn't be uploaded until "add icon" is clicked?

Drat, thought I fixed that, I'll work on it. I unfortunately can't do uploads like that for technical reasons.

Tech explanation: the website is built in Ruby on Rails, which is single threaded, and using a single dyno on Heroku cause more cost money. And uploading images is slow. Which means that if someone uploads a bunch of images, that's *the only thing the site can do* until the uploads complete. Which is not optimal :D I could try to muck with the JavaScript, but the current version is mostly taken from the Heroku How To Upload Images guide, which was faster.

[Throne3d]

~snip~

Drat, thought I fixed that, I'll work on it. I unfortunately can't do uploads like that for technical reasons.

Tech explanation: the website is built in Ruby on Rails, which is single threaded, and using a single dyno on Heroku cause more cost money. And uploading images is slow. Which means that if someone uploads a bunch of images, that's *the only thing the site can do* until the uploads complete. Which is not optimal :D I could try to muck with the JavaScript, but the current version is mostly taken from the Heroku How To Upload Images guide, which was faster.

It might work if, when they clicked the button, JavaScript tried uploading the buttons then, and then pushed a hidden submit button for them once it's done? (And to fail more gracefully without JavaScript, maybe have the submit button rendered by default, then swapped out for the JavaScript one on document load by JavaScript.)
It should then still be client-side, but look more like a regular server thing.

[Marri]

That would definitely be more graceful! But I'm currently using a Javascript library that does file uploads at time of file selection, so I'd need to find something to swap it out with / figure out how to change the call time.

[Marri]

Some changes from Throne3d are now up: The Icon/List links now change color depending on what view you're in, and the code for the Preview button now lives in a more sensible place.

I have also written more tests, but that has no particular impact on using the site.

[Marri]

I have changed how I link to posts. It shouldn't break the old links, if you were using those, but the new ones are in theory better because they'll automatically adapt to your posts-per-page setting instead of overriding it.

Previous format: /posts/48?per_page=all#reply-7086
New format: /replies/7086#reply-7086

Email notifications are almost done but I'm having design stress. (I mean, I have it pretty globally about the whole site, even I get the Next Post and Next Page buttons mixed up and that indicates serious UI issues, but the emails in particular!) So if people better than design at me have opinions, please do tell, I welcome and encourage them :D this is so not my strong suit.